Add 'returning' or 'new' booking type selection when making an appointment

TheProductWorks / smart_client

0 stars 0 forks source link

Add 'returning' or 'new' booking type selection when making an appointment #103

Open sciritai opened 9 years ago

sciritai commented 9 years ago

Story

As a midwife or admin I'd like to be able to make a double booking for a new woman who has entered the program. I need to be able to select from a list one option of 'returning' or 'new'.

API docs are updated here: https://github.com/TheProductWorks/smart_client/blob/master/doc/api.md#post-appointments

Tasks

Add a dropdown to select either option in the Android client
The return_type is the key to add to the POST request and the server will take care of the rest.

Example from the admin interface:

screen shot 2015-05-28 at 13 00 04

otormaigh commented 9 years ago

Added option to making appointment to allow user to select appointment type device-2015-06-01-131054

Wogiebear commented 9 years ago

What: issue scrub When: Fri 05-Jun-2015 Who: Elliot, Conor

Feedback

"Select Type" placeholder hint is too alike the field names. Aim: get the "Select type" text to match the hint style being applied throughout (i.e. italics, #A9A9A9)
There is too big a horizontal gap between the down arrow and the text, such that the user may not know to click to select an option. Aim: put the down icon over a square grey button, just like the search icon.

otormaigh commented 9 years ago

Done device-2015-06-14-113603

Wogiebear commented 9 years ago

@sciritai, just talking to @otormaigh about this. Can you extend the response back for a 'New' booking to show the 2 slots that were booked, so the client don't have to think so much?

sciritai commented 9 years ago

Returning multiples from a POST request breaks the REST contract. The ember client wouldn't be able to handle it. If we want to do it properly then it'd return an appointment of length 30 mins, we'd need to introduce a duration for the appointment. Would then need to change the clients to read the duration instead. Not certain how much is involved but could be tricky.

Alternatively I could add the return_type key to the response so the client would just insert the same object twice into it's model.

otormaigh commented 9 years ago

Done.

User can book 'New' appointment and the Android app will populate the list of appointment with both appointments

Wogiebear commented 9 years ago

[testing]

Change placeholder text: -"Select Return Type" -> "Select appointment type"

otormaigh commented 9 years ago

Changed "Select Return Type" to "Select appointment type"