search

TheProjecter / phantomjs-qunit-runner

Automatically exported from code.google.com/p/phantomjs-qunit-runner
0 stars 0 forks source link

Dependencies should be listed before the test file and the SUT #13

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Create a source file that requires/uses a third party library (eg: jQuery)
2. Create a test for that file
3. Run that test via Maven/phantomjs-qunit-runner with the library specified 
via <includeLibsInDir>

What is the expected output? What do you see instead?

The expected output should be that the test passes.  The current defect is that 
the test doesn't pass.

What version of the product are you using? On what operating system?
phantomjs-qunit-runner 1.0.15, Ubuntu, Java version "1.6.0_21", Phantomjs 1.7.0

Please provide any additional information below.

When phantomjs loads the SUT (that requires the third party library) the 
library is provided to phantomjs *after* the Javascript code that requires it.  
This does not make sense as a dependency should always be listed *before* the 
code that uses that dependency.

I have suggested a patch that will fix this problem, however a new release will 
need to be made.

Original issue reported on code.google.com by kierans...@gmail.com on 29 Oct 2012 at 4:20

GoogleCodeExporter commented 8 years ago 
The same defect happens in the HTML generation.  I've suggested a patch (see 
Issue 15)

Original comment by kierans...@gmail.com on 31 Oct 2012 at 11:53

GoogleCodeExporter commented 8 years ago 
Guys Thank you for the plugin and all your work 
Any plans on the new release with this bug fixed ? ;-)

Original comment by danielcz...@gmail.com on 10 Dec 2012 at 11:28