TheProlog / prolog-use_cases

Use-case layer for Meldd/Prolog application.
0 stars 0 forks source link

Redundant :repository parameter in RetrieveSingleArticle#call #15

Open jdickey opened 8 years ago

jdickey commented 8 years ago

A repository interface to the persistent store for Prolog::Core::Article is passed into the initialiser for Prolog::UseCases::RetrieveSingleArticle. Why, then, as of Gem release 0.4.0, must we also pass it in as part of the parameter Hash to #call? The instance variable created by #initialize is not used anywhere else in the class.

This stinks. Not badly enough to drop everything and fix it, but that may change as experienced pain levels increase. The reason it wasn't fixed as part of 0.4.0 was that we merged the feature branch before recognising the problem, and future progress on other use cases appears to outweigh the benefit of an immediate fix.