search

TheProlog / prolog-use_cases

Use-case layer for Meldd/Prolog application.
0 stars 0 forks source link

ProposeEditContribution should persist the updated Article on success. #29

Closed jdickey closed 8 years ago

jdickey commented 8 years ago

After all, it has an article_repo parameter that it presently (as of Commit d44c1f5) doesn't do anything with. :astonished:

The contribution proposal is being persisted; which jogs the mind to consider a related issue: how would persistence errors (in either or any repository) be bubbled back up to the use case and its client, at the delivery-system border? Currently, it appears that we assume any failures to persist created or updated data simply allow that data to fall on the floor. This is highly unlikely to be desirable behaviour.

jdickey commented 8 years ago

And yes, the requirements clearly state that

[an] updated record for the Article must have been persisted to the Article Repository…

So that puts this clearly on the 0.7.0 bucket list. Comments continue to be welcomed regarding the second paragraph in the opening comment (what do we do about persistence failures?)