search

TheProlog / prolog-use_cases

Use-case layer for Meldd/Prolog application.
0 stars 0 forks source link

Query Proposed Contributions to Single Article #34

Closed jdickey closed 8 years ago

jdickey commented 8 years ago

Implements the Query Proposed Contributions to Single Article use case.

This is the first post-publication use case specific to the Author of an Article.

This is also the first Use Case implementation to not use the established convention of a form object for attribute collection and validation.

jdickey commented 8 years ago

One bit in the commit essay for Commit 210e69b bears calling out for later attention:

Note the caveats in the modified .rubocop.yml. Style/FrozenStringLiteralComment is disabled by default, simply because it would require adding a comment to every single .rb file that won't have any actual effect until Ruby 3.0. However, enabling it did allow us to find and fix a subtle test-fixture bug in body_marker_test.rb; see if you can spot it. 😀

Note for future maintainers: as any files are changed henceforth, add the Ruby 3.0 frozen-string pragma comment to the files being modified and ensure that all tests still pass. Once RuboCop's Style/FrozenStringLiteralComment cop can be enabled in .rubocop.yml without error, leave it enabled (i.e., after all source and test files have the pragma comment).

jdickey commented 8 years ago

Closed as of Commit 33030cf.