search

TheProlog / prolog-use_cases

Use-case layer for Meldd/Prolog application.
0 stars 0 forks source link

Fix the FIXMEs. #54

Open jdickey opened 8 years ago

jdickey commented 8 years ago

As of Commit c3f0101, ten files (9 under lib and 1 under test) have FIXME notes. These are:

  1. lib/prolog/entities/article_ident_v.rb line 9;
  2. lib/prolog/use_cases/propose_edit_contribution/update_article_with_marked_body.rb lines 41-42;
  3. lib/prolog/use_cases/propose_edit_contribution/validate_attributes.rb lines 14-17;
  4. lib/prolog/use_cases/propose_edit_contribution.rb lines 25-27;
  5. lib/prolog/use_cases/publish_new_article/form_object.rb line 11;
  6. lib/prolog/use_cases/publish_new_article.rb line 10;
  7. lib/prolog/use_cases/respond_to_single_proposal/result.rb line 12;
  8. lib/prolog/use_cases/respond_to_single_proposal.rb lines 13-17;
  9. lib/prolog/use_cases/retrieve_article/form_object.rb line 25;
  10. test/prolog/use_cases/register_new_member/form_object_test.rb lines 35-39.

These should be relatively easy to fix, piecemeal, as the opportunity arises. Many, but not all, are Reek complaints about "too many instance variables/methods", strongly implying an SRP violation baked into how i think about that particular class.