TheRacetrack / racetrack

An opinionated framework for deploying, managing, and serving application workloads
https://theracetrack.github.io/racetrack/
Apache License 2.0
28 stars 5 forks source link

Deployment getting stuck at finalizing the build phase #461

Closed iszulcdeepsense closed 1 month ago

iszulcdeepsense commented 1 month ago

Fixed

Long deployments (over 20 minutes) no longer get stuck in the final stage.

This is done by switching to Server-Sent Events, sending heartbeat messages to keep alive the connection during long requests.

Plus, couple of improvements in FastAPI ASGI app to clean up the request properly (and show logs) if a client disconnects.

iszulcdeepsense commented 1 month ago

Looks good. Is the root cause confirmed to be fixed by the heartbeat thing?

Even if not, this looks useful and ready to merge.

Yes, I've checked it on the test cluster and it worked