search

TheRandomCrew / Private-Events

Users can create events and send invitations and parties. Events take place at a specific date and at a location.
MIT License
2 stars 1 forks source link

add a delete button on the events created by the user. #40

Closed S-Toky closed 3 years ago

Israel-Laguan commented 3 years ago

it needs to have a backend implementation first so frontend would just pick up. Please create an issue or a PR with the backend changes to support deleting an event.

S-Toky commented 3 years ago

Capture du 2021-04-07 18-42-03 this is the picture I wanted to say about the delete button, so on the back, in the controller, the delete method is already there but for the user to be able to remove an event he is the author, it must be implemented in case the user will cancel the event.

Israel-Laguan commented 3 years ago

Ahh perfect, if the backend have the method, please add the delete under one condition, only the creator of the event should delete it, any other one invited doesn't should be capable to delete an event

S-Toky commented 3 years ago

ok, I'll see that and do it

S-Toky commented 3 years ago

I finished coding the delete button with the conditions, I do the git push on my branch so?

S-Toky commented 3 years ago

it is done and pusher on the branch SToky. working hour 1h

Israel-Laguan commented 3 years ago

SToky is not a good name for a branch. For this case I suggest 40-add-delete-button. For future PRs please check this: https://deepsource.io/blog/git-branch-naming-conventions/

S-Toky commented 3 years ago

ok, I will make the new push with the right name

Israel-Laguan commented 3 years ago

Solved in #54