search

TheRandomCrew / seosemapi-frontend

0 stars 0 forks source link

Doubt #4

Open Saikilito opened 5 years ago

Saikilito commented 5 years ago
  1. Data password not hash in the browser (search image)?
  2. In the dashboardView component is mixed logic component with views components ?
  3. Not use useNewFetch ?
  4. Routes link in spanish ?
  5. "cleanCache" (img or button) at loading ?
  6. Cards components is not reusable ?
Israel-Laguan commented 5 years ago

1) Sorry, explain this 2) I'll change later 3) Is new! I want to use it in new components and migrate the other 4) yes, client wanted them in Spanish. I have to change some routes yet, like dahsboard or home 5) Is something that deserves an issue on its own 6) we can change that

Saikilito commented 5 years ago

1.01 ) Yesterday I found from the "React Developers Tools" in the browser my user and password revealed but I forgot to take a capture then I look for it because I do not remember what component it looked, but it would be good to check that

Israel-Laguan commented 5 years ago

Get it. Yes, the credentials treatment must change.

Saikilito commented 5 years ago

Capture of problem

1.02)

password-and-user

it is in the context provider

Saikilito commented 5 years ago

Doubt 2

  1. In the useFetch where compare the bd data with form data ?
    • this info is a request of get ??
  2. The overview.jsx file have a logic a bit confusing, i dont understend
  3. TimelySearches seems not connected to any other component
  4. The dashboard navbar do not have a link for browser to home
Israel-Laguan commented 5 years ago

1) is a get 2) sorry :pensive::persevere: 3) I've used before but forgot to erase the file lol 4) That is a client request