Forever loading with void world generator (1.12.2)

[mchorse]

Hello there!

There is an issue with Void world generator. When I create a world with this world generator, it's starts generating and when it reaches "Loading world", it just freezes. Freezes as in doesn't do anything. The status of Minecraft doesn't become "(not responding)," it's just freezes.

Here is a debug.log, if you want to take a look at it. Although it doesn't seem to yield any exceptions or errors.

I would really appreciate if you could fix this, because that seems like a very useful world for messing around with no terrain at all 🙂

[TheRandomLabs]

Could you install the latest version of RandomTweaks and try again? I may have fixed a similar issue already.

On Sat, 14 Jul 2018 at 07:15 McHorse notifications@github.com wrote:

Hello there!

There is an issue with Void world generator. When I create a world with this world generator, it's starts generating and when it reaches "Loading world", it just freezes. Freezes as in doesn't do anything. The status of Minecraft doesn't become "(not responding)," it's just freezes.

Here is a debug.log https://github.com/TheRandomLabs/RandomTweaks/files/2194204/debug.log, if you want to take a look at it. Although it doesn't seem to yield any exceptions or errors.

I would really appreciate if you could fix this, because that seems like a very useful world for messing around with no terrain at all 🙂

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TheRandomLabs/RandomTweaks/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/AP-r-FX41wZ6MPYAuql5RDI540Ba5fmEks5uGQ4JgaJpZM4VPhQU .

[mchorse]

No, unfortunately, it didn't solved the issue. It's still freezing whenever I try to load or create a new void world.

[TheRandomLabs]

Alright, I'll take a look at it.

On Sat, 14 Jul 2018 at 19:06 McHorse notifications@github.com wrote:

No, unfortunately, it didn't solved the issue. It's still freezing whenever I try to load or create a new void world.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TheRandomLabs/RandomTweaks/issues/22#issuecomment-405010356, or mute the thread https://github.com/notifications/unsubscribe-auth/AP-r-LAa0K11xOoKiwi3LbwPVpftZ2Egks5uGbSfgaJpZM4VPhQU .

[TheRandomLabs]

I haven't been able to reproduce this issue. Does the game freeze while loading Void Islands or Realistic worlds as well?

[mchorse]

Hmm, that's weird. Game doesn't freezes with Realistic world, but I decided to disable few of my mods, and did a few additional tests, and Void works if I remove some of my mods.

I don't know what exactly causing this, but... apparently Teletubbies mod causes the game to freeze 😂

I'm sorry for disturbing you with such a stupid thing 🤣

[TheRandomLabs]

Great, I'll have a look at the Teletubbies mod tomorrow.

On Sun., 15 Jul. 2018, 18:17 McHorse, notifications@github.com wrote:

Hmm, that's weird. Game doesn't freezes with Realistic world, but I decided to disable few of my mods, and did a few additional tests, and Void works if I remove some of my mods.

I don't know what exactly causing this, but... apparently Teletubbies mod causes the game to freeze 😂

I'm sorry for disturbing you with such a stupid thing 🤣

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TheRandomLabs/RandomTweaks/issues/22#issuecomment-405075314, or mute the thread https://github.com/notifications/unsubscribe-auth/AP-r-Hbiawb5b_kup0DmE-l3d74i0fu6ks5uGvqVgaJpZM4VPhQU .

[mchorse]

I took a look at it, and looks like the issue is in GenTubbyVoiceTrumpet class:

    /* func_180495_p = getBlockState(), func_177230_c = getBlock() */
    while ((world.func_180495_p(pos).func_177230_c() instanceof BlockAir))
    {
      yCoord--;
      pos = new BlockPos(xCoord, yCoord, zCoord);
    }

I think it gets stuck over here. I'll report that to Teletubbies mod dev.

[TheRandomLabs]

Yeah, the author forgot to exit the loop if Y reaches 0. I'm not sure if there's something I should do differently, but I've reported it to the author as well.

[mchorse]

I think your mod is fine, thanks for working on this issue with me, sorry if I disturbed you 😁