TheRandomLabs / RandomTweaks

A bunch of miscellaneous tweaks for Minecraft.
https://minecraft.curseforge.com/projects/randomtweaks
MIT License
8 stars 2 forks source link

Crash on loading if forced world generation is enabled and conflicting with another world gen mod doing the same. #27

Closed DWX12 closed 6 years ago

DWX12 commented 6 years ago

Long story short, if there's another mod that also has a forced world gen setting enabled, the game will crash on loading. The only suggestion I have to avoid this issue is a warning, upon load, if RandomPatches can detect another mod is trying to force world gen as well.

I encountered this with Hexlands and am glad I had thought that this was the issue.

Great mod. Thank you or all of your hard work and effort, it's well appreciated.

Edit: This is after trying to load Minecraft with the realistic world gen set to false and still got a crash: https://paste.dimdev.org/difaroxuha.mccrash

Apparently I read it incorrectly and it doesn't force world generation of a specific type if any of the configs are set to true; however, Hexlands does if that config is set to true. And by force, I mean if you start up a default world the generation will be Hexlands or BOPHexlands if you tell it to do so in the config.

Edit 2: Seems to only crash if this is set to true: Force overworld hex generation even when world type is not selected Default: false B:forceHexGen=false

I also have the dimension set to 0: What dimension ID to use Default: 88 I:dimID=0

TheRandomLabs commented 6 years ago

Interesting, looks like Hex Lands changes the WORLD_TYPES array so that it only accepts WorldTypeHexLands. This is fixed in 1.12.2-2.1.7.1.

DWX12 commented 6 years ago

Many thanks, you're quick. Again, sorry about posting issue on the wrong mod, lol.

TheRandomLabs commented 6 years ago

It's fine, haha. You forgot to change RandomPatches to RandomTweaks here as well. It might take a bit for it to be accepted on CurseForge.