search

TheRandomLabs / Scoop-Spotify

A Scoop bucket for Spotify, Spicetify and related packages.
The Unlicense
178 stars 14 forks source link

Spotify doesn't work with BlockTheSpot #65

Open rollingmoai opened 2 years ago

rollingmoai commented 2 years ago 
scoop install spotify-latest
scoop install blockthespot

However, it does work when I install spotify manually (through the exe) and apply BlockTheSpot manually.

karthikvinayan commented 2 years ago

I've fixed this issue but since @TheRandomLabs is not responding I've forked this repo and added all the fixes there. Feel free to check it out. It is because of a slight change in the way the blockthespot patch is to be applied

@itsmeboy0

rollingmoai commented 2 years ago

I've fixed this issue but since @TheRandomLabs is not responding I've forked this repo and added all the fixes there. Feel free to check it out. It is because of a slight change in the way the blockthespot patch is to be applied

@itsmeboy0

Okay, can you create a PR for the BlockTheSpot fix in this repo?

karthikvinayan commented 2 years ago

I've fixed this issue but since @TheRandomLabs is not responding I've forked this repo and added all the fixes there. Feel free to check it out. It is because of a slight change in the way the blockthespot patch is to be applied @itsmeboy0

Okay, can you create a PR for the BlockTheSpot fix in this repo?

I could but I don't think @TheRandomLabs will respond. This repo is run just with GitHub Actions now. I've tried several ways to contact him. There are already several PRs to be merged in this repo, all of them have gone unnoticed.

The Blockthespot error is just one of many, but the other ones go doesn't break anything, they're just inconveniences.

rollingmoai commented 2 years ago

Spotify and Spicetify has just been added to the official buckets (https://github.com/spicetify/spicetify-cli/issues/1290#issuecomment-1062704879), and I am happy with it. There is no need for this repo (and that fork) anymore as an AdBlock extension exists in Spicetify.

I will keep this issue open for reference and for other people to find.