TheRandomLabs / scoop-nonportable

A Scoop bucket for nonportable applications.
The Unlicense
137 stars 40 forks source link

Nvidia driver autoupdate seems misbehaving. #198

Closed escape0707 closed 3 years ago

escape0707 commented 3 years ago

Please review recent commits made by bots.

Updating 'nonportable' bucket...
 * 45727e4 everything-beta-np: Update to version 1.4.1.994               2 hours ago
 * 15b6b15 nvidia-display-driver-with-3d-vision-np: Update to version .. 10 hours ago
 * 05c5625 nvidia-display-driver-np: Update to version 456.71            10 hours ago
 * 0c620e4 nvidia-display-driver-dch-with-3d-vision-np: Update to vers.. 10 hours ago
 * ff0968b nvidia-display-driver-dch-np: Update to version 456.71        10 hours ago
 * 3ce6592 nvidia-display-driver-with-3d-vision-np: Update to version .. 11 hours ago
 * 083f64c nvidia-display-driver-np: Update to version 456.55            11 hours ago
 * 85a4640 nvidia-display-driver-dch-with-3d-vision-np: Update to vers.. 11 hours ago
 * 491f405 nvidia-display-driver-dch-np: Update to version 456.55        11 hours ago
 * 86b8988 nvidia-display-driver-with-3d-vision-np: Update to version .. 12 hours ago
 * 208436d nvidia-display-driver-np: Update to version 456.71            12 hours ago
 * 0bd2156 nvidia-display-driver-dch-with-3d-vision-np: Update to vers.. 12 hours ago
 * d5a1574 nvidia-display-driver-dch-np: Update to version 456.71        12 hours ago
 * 54e67f3 nvidia-display-driver-with-3d-vision-np: Update to version .. 13 hours ago
 * 6146a5b nvidia-display-driver-np: Update to version 456.55            13 hours ago
 * ea586df nvidia-display-driver-dch-with-3d-vision-np: Update to vers.. 13 hours ago
 * 406f655 nvidia-display-driver-dch-np: Update to version 456.55        13 hours ago
TheRandomLabs commented 3 years ago

I'm not sure why this is happening; the list here is showing 456.71 as the latest version.

escape0707 commented 3 years ago

Weird. I just looked the documentation of checkver mechanism and it seems that the Nvidia download html page gives wrong order or wrong version at some point. Is there a way to dump the html when a downgrade of checkver happens?

TheRandomLabs commented 3 years ago

I don't think so, but I'm not well-versed enough in GitHub Actions to know for sure.

escape0707 commented 3 years ago

Okay, I'll try to look into it.

TheRandomLabs commented 3 years ago

Oh, thank you. You're a legend. 😄

escape0707 commented 3 years ago

I looked up the debug log of some recent github actions. The action defined by https://github.com/Ash258/Scoop-GithubActions does say it sometimes finds 456.55 as the "latest version", but most of the time it do thing correctly.

I don't think I'll dive into Ash258's repo that soon. I'm write a python script and setup scheduling task to download and compare the html linked by checkver:url every hour, just before the github action started.

If this wrong behavior happens again and I caught the wrong html page, too. Then it's a Nvidia problem and we might have to find some other checkver options. If the html I get just before the github action is correct but still the github action updates the repo with wrong info, then we can't avoid diving into Ash258's code.

escape0707 commented 3 years ago

Actually, I didn't catch any NVIDIA side HTML problem.

This bug isn't always happening at each time GitHub action Excavator runs. Looking at the the log and the source code of the action, the problems happens when this script executes. It setups a lot of environment variables then invoke scoop's auto-pr.ps1. And the latter script invoke checkver.ps1, then responses with a false "new version".

When I run checkver.ps1 on my machine, I always get a correct latest version number. Can't easily reproduct the problem on my side. I think setup Ash258's script according to what he wrote and debug locally might be needed. To do the debugging, changing Ash258's script or even the original checkver.ps1 downloaded by Ash258's script is required, too. The problem don't always reproduce either. So the related knowledge scope of the bug is beyond that I expected. -_-

I have some questions for now. First, is this repo using the correct version of Ash258's script? He suggested stable-win branch but what's the meaning of the master branch? Second, I see the Excavator is setup to use Shovel perhaps that needs to be checked for potential problems, too?

I don't think I could figure all these out now, have to prepare for recent exams....

TheRandomLabs commented 3 years ago

Yes, I'm using the stable-win branch and Shovel. The master branch is no longer supported and runs on Linux rather than Windows. I don't know if Shovel is particularly reliable, but I needed it for my spotify bucket, so I swapped over here to keep things consistent. I'll try disabling Shovel to see if it changes anything. I also have exams coming up, so if that doesn't work, I'm not able to dedicate a lot of energy to this. Thanks for looking into this!

TheRandomLabs commented 3 years ago

The issue still persists without Shovel. 😑

TheRandomLabs commented 3 years ago

Strangely, the issue seems to be resolved.

maokwen commented 2 years ago

TinyNvidiaUpdateChecker hosts a website which gets the correct version.