TheRareFox / pe

0 stars 0 forks source link

Inconsistent delete error messages #6

Open TheRareFox opened 1 week ago

TheRareFox commented 1 week ago

For deletion error messages, this error message is thrown.

image.png

However, when the index is big enough, the error message thrown is different.

image.png

There is inconsistency with what the error message displays, especially since the index is still a positive integer, and it is not a invalid command format, hence the error that is thrown is inaccurate.

nus-se-bot commented 1 week ago

Team's Response

Thank you for your report! This has been mentioned in planned enhancements, where we aim to standardise error messages and make them more specific.

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Not specific Error Message

From this error message, the user would not know what are the requirements for duplication and which field is duplicated. A more concise error message is preferred.

image.png


[original: nus-cs2103-AY2425S1/pe-interim#1883] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your report! We have mentioned in our Planned Enhancements that we aim to have more targeted error messages.

image.png

Additionally, our User Guide mentions what a duplicate entry entails:

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: This is different from the duplicate issue as the duplicate issue is about an error message being not concise, while this issue is about a completely wrong and misleading error message.

image.png

This error message is wrong as the index entered is clearly a positive integer, but it is still being rejected.


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Thank you for responding! I believe this is not covered under planned enhancements as this is a wrong error message, while your planned enhancements mentioned to just make error messages more specific and standardised. ![image.png](https://raw.githubusercontent.com/TheRareFox/pe/main/files/4a80c461-73f9-441f-8ef8-15ff325bc770.png) However, this is not just about standardising error messages, as the error message in the screenshot is wrong. ![image.png](https://raw.githubusercontent.com/TheRareFox/pe/main/files/4810e94b-d37b-48a8-96d9-dafd4d2d15f5.png) Even though the index entered is clearly a positive integer, but it is still being rejected with an error message. This I believe is an unintended feature and not fixed by the proposed change of `introducing more specific error messages for the command format`, since this already has a specific error message to address the issue. Instead, this error message should be coded to cover a wider range of integers, or limiting the integers you can enter to a certain size. ![image.png](https://raw.githubusercontent.com/TheRareFox/pe/main/files/c6491f89-3a4e-45ba-945e-782ca64be0a7.png)
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]