Crash when doing "sought all"

What steps will reproduce the problem?
I'm honestly not sure.

What is the expected output? What do you see instead?
I expected to stay connected to the chess server. Instead, I got dumped.

What version of the product are you using? On what operating system and
what environment?
.98u3f5

Please provide any additional information below.
[13:22:07] so all
[13:22:07] Error occured! We are trying to make Raptor bug free and we need 
your help! Please take a moment to report this issue by selecting the menu:
  Help -> Report Issue 

TimesealSocketMessageProducer Connector Error in DaemonRun Thwoable
java.lang.RuntimeException: Error occured parsing message:   2 1727  TheOldGorm 
         3   0 rated   blitz               1700-9999 
  3 2415  jeisonmartinez      3   3 rated   atomic              2201-9999 
  8  937E ganbatte           10   0 unrated blitz                  0-9999 m
 12 2328  parrot(C)          28   1 rated   standard               0-9999 f
 14 1759  Datalorecw          5   0 rated   blitz               1700-9999 f
 19 1353  GreatSachin         0   2 rated   lightning              0-9999 
 25 1159  larsfriedner       10   0 rated   blitz                  0-9999 f
 26 2555E Sordid(C)           3   0 unrated atomic                 0-9999 f
 27 1491  popasile            4   0 rated   blitz               1550-9999 
 29 1656  deltax             10   0 rated   suicide                0-9999 m
 30 1624  sibiriacalgary      5   3 rated   blitz               1750-9999 f
 31 1053  Feestt              5   5 rated   blitz                  0-1200 mf
 32 1353  GreatSachin         0   3 rated   lightning              0-9999 
 35 ++++  GuestJRHL          60  30 unrated standard   [white]     0-9999 m
 36 2674  stayalive(C)        3   0 rated   suicide                0-9999 f
 38 1394  saggitarian        10   0 rated   blitz               1200-9999 f
 40 2674  stayalive(C)        3   0 unrated suicide                1-9999 
 46 2991  pindakaas(C)        4   0 rated   suicide                0-9999 mf
 47 1860  Teena               3   0 unrated losers                 0-9999 
 48 1411  Parishable          4   0 rated   blitz      [white]  1350-9999 f
 53 2172  parrot(C)           2  12 rated   blitz                  0-9999 f
 54 ++++  GuestPGYS           6   0 unrated suicide                0-9999 
 59 1444  arjivo              4   5 rated   blitz               1200-2999 f
 61 2674  stayalive(C)        2  12 rated   suicide                0-9999 f
 66 2991  pindakaas(C)        4   0 unrated suicide                0-9999 mf
 67 1308  Matinovsky          5   5 rated   blitz                  0-9999 
 71 1482  AbdouOrabi          5  12 rated   blitz               1450-1650 f
 72 ++++  YOUareSTUPID       10  30 unrated standard   [white]     0-9999 m
 73  953P coolboysaurav      30  30 unrated standard   [white]     0-9999 m
 84 ++++  GuestDJMN          10  30 unrated standard               0-9999 m
 89 2181  Spahi               3   0 rated   blitz               1900-9999 mf
102 1203  sjames              5   0 rated   blitz                  0-9999 f
104  790P luwals              5   5 rated   blitz      [white]     0-9999 
112 1238  kaminiraviraj       3   0 unrated blitz      [white]     0-9999 m
114 1801  DonCid              1   0 rated   lightning              0-9999 f
117 2304  GnuCheese(C)        2  12 rated   blitz                  0-9999 mf
122 1563  fastfoxy            1   0 rated   lightning              0-9999 
123 1353  freedoor            5   3 rated   blitz                  0-9999 
126 2420  GnuCheese(C)       15   5 rated   standard               0-9999 mf
129 2535  GnuCheese(C)        1   0 rated   lightning              0-9999 mf
133 1987  VrtX                3   0 rated   crazyhouse             0-9999 
135 1430  Bilt                0   4 rated   lightning              0-9999 
138 1872  venkosla            2   1 rated   lightning           1650-2000 
145 1936  Kolumbus            1  10 rated   wild/fr                0-9999 f
157 1525  Yory                5   0 rated   blitz               1300-9999 f
165  996  vlaskmbhr          30  30 unrated standard   [white]     0-9999 m
169 2231  parrot(C)           1   0 rated   lightning              0-9999 f
179 1987  VrtX                2   0 rated   crazyhouse             0-9999 
194 ----  QBall              60   5 unrated odds/queen-and-move [black]     0-  
 0 mf
198 1707  Beyatch             3   5 rated   blitz               1600-2000 f
50 ads displayed.
fics% 
    at raptor.connector.ics.IcsConnector.parseMessage(Unknown Source)
    at raptor.connector.ics.IcsConnector.messageArrived(Unknown Source)
    at raptor.connector.ics.timeseal.TimesealSocketMessageProducer.messageLoop(Unknown Source)
    at raptor.connector.ics.timeseal.TimesealSocketMessageProducer$1.run(Unknown Source)
    at java.lang.Thread.run(Thread.java:679)
Caused by: java.lang.NumberFormatException: For input string: "and"
    at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
    at java.lang.Integer.parseInt(Integer.java:481)
    at java.lang.Integer.parseInt(Integer.java:514)
    at raptor.connector.ics.SoughtParser.parse(Unknown Source)
    at raptor.connector.ics.IcsParser.processSought(Unknown Source)
    at raptor.connector.ics.IcsParser.parse(Unknown Source)
    ... 5 more

[13:22:07] Disconnected

Original issue reported on code.google.com by skqui...@gmail.com on 10 Aug 2012 at 6:23

I have been able to reproduce this issue by doing: "seek 60 5 odds 
queen-and-move black manual f" just like QBall did in the example and then 
viewing the seek with "sought all". My guess is that the dashes in 
"queen-and-move" crash the connection because "seek 60 5 odds rook-and-move 
black manual f" will cause the same problem.

Because this not only throws an error but kills the connection to FICS I will 
change this to Medium priority.

Looking further into this problem I find that when Raptor displays a sought 
list in the console and there happens to be a line with brackets such as (C) 
Raptor will think that this line is a news item and double clicking on it will 
attempt to open the news item with the beginning number's index.

You can notice through experimenting that Raptor always changes the rating 
range to "0-   0" if the seek was issued by a registered user with a rating of 
"----", but Raptor will keep the actual rating range if the seek was issued by 
a guest with a rating of "++++"

There are 22 board types that contain dashes and I assume they all kill 
Raptor's connection to FICS when viewed with the sought command:

misc/queen-power
misc/no-castle
misc/knight-power
misc/no-queens
misc/bishops-only
misc/rook-power
misc/rooks-only
misc/knights-only
misc/minor-power
misc/bishop-power
misc/queens-only
misc/queen-rooks
misc/full-power
odds/knight-and-move
odds/pawn-and-move
odds/queen-and-move
odds/rook-and-move
odds/bishop-and-move
pawns/little-game
pawns/pawns-only
pawns/wild-five
pawns/pawn-power

This bug is an interesting and important one and I'd love to try and figure it 
out but I know nothing of Raptor's parsing code other than it is probably 
really complicated. While this specific bug is important, there will *always* 
be FICS messages that Raptor has trouble understanding. How do all the other 
interfaces deal with the extremely rare cases that should put the interface 
into a panic?

Original comment by jessego...@gmail.com on 3 Feb 2013 at 11:28

Changed state: Accepted
Added labels: Priority-Medium
Removed labels: Priority-Low

TheRealCDay / raptor-chess-interface

Crash when doing "sought all" #676