search

TheRealDjmr / BG3ImprovedUI

135 stars 132 forks source link

Bloodletter subclass icon added #248

Closed 72division closed 10 months ago

72division commented 10 months ago

Adding Bloodletter rogue subclass icons. Many thanks.

GitHub : https://github.com/72division/BG3_Bloodletter

72division commented 10 months ago

Hi, please check the details and consider my request. Thanks.

TheRealDjmr commented 10 months ago

Heya, no worries.

I've had a look at the Git repository and found a few issues:

  1. You have Class icons listed in both Dynamic and Direct paths. You only need one or the other - https://bg3.wiki/wiki/Modding:Modding_class_icons
  2. You don't have any action resource icons located in Assets/Bloodletter/Shared/Resources/ - you only have the controller icon location only.

Also, the "Source" entries in ImprovedUI/Public/Game/GUI/Library/IUI_ActionResourceTemplates_c.xaml are just wrong, they just need to point to your controller action resource icon.

72division commented 10 months ago

Hi, thanks for your guides. I have fixed the mistakes. Please check the details. Have a good one!

72division commented 10 months ago

Many thanks! I'm looking to publish this mod on Nexusmods soon. Is there a possibility that it will be included in the upcoming release, and if so, could you provide an estimate of when that might be?

TheRealDjmr commented 10 months ago

Thanks for the interest, I try to get updates out every Friday/Saturday around my free time and dropping new features. Since I've released the majority of the updates, it all falls upon me. Happy to have any help!

Yesterday I fixed the final issues I found to your entries and downloaded a copy of your mod from your repository, packed ready for testing.

Today I've tested both icon sets: 20240105210456_1 The action resource images are not setup correctly - The file extension is set to .dds instead of .DDS (like your class icons are), they are set to 50x50 instead of 48x48, and don't even show unless I recreate the .DDS file (maybe its an issue with how you're generating .DDS images?). Here's a screenshot after I resized your default icon and changed the paths for keyboard: 20240105212802_1 and how things currently look for controller users, with your supplied icons, even after I updated the file path locally: 20240105212836_1

Here's the resized and recreated icon as an idea of what works - ico_classRes_BloodEssence.zip

Controller icons can actually be bigger - up to 80x80 depending on how you want them displayed for tooltips, but 50x50 should be fine (they are resized to 50x50 for the action radial if you want them like how others have entered them)

TheRealDjmr commented 10 months ago

Here's a copy of ImprovedUI Assets with the test entries so you can check it out from your end - ImprovedUI Assets (bloodletter test).zip

TheRealDjmr commented 10 months ago

The entries with .dds extensions are included in #250

72division commented 10 months ago

Here's a copy of ImprovedUI Assets with the test entries so you can check it out from your end - ImprovedUI Assets (bloodletter test).zip

Thanks for your help! I`m going to fix other icons.

TheRealDjmr commented 10 months ago

As mentioned yesterday, I dropped the ImprovedUI Assets update today. This includes the bloodletter entries as above. Keeping this open until the icons are sorted

72division commented 10 months ago

I think I have fixed .dds issues. Can you kindly check my pak file again? I have attached the latest .pak file.

Many thanks. [Uploading Bloodletter.zip…]()

or you can download here

TheRealDjmr commented 10 months ago

You should be able to check it too though, since the entries are in the latest version 20240107191903_1 20240107192002_1 I've added Bloodletter to the list of supported mods