TheRealDjmr / BG3ImprovedUI

134 stars 132 forks source link

Add action resource icons for ReRoller mod #288

Closed victor-takai closed 8 months ago

victor-takai commented 9 months ago

Here's my mod, let me know if there's anything wrong.

victor-takai commented 8 months ago

@TheRealDjmr is there something wrong with my request?

TheRealDjmr commented 8 months ago

@TheRealDjmr is there something wrong with my request?

Hey, I'd appreciate not getting pinged. I'm happy to chat over Discord.

You may have noticed that we've had Patch 6 and 2 hotfixes within a week, I've had to prioritise those over requests. Even before that, there's been a backlog for a range of reasons, such as travelling across multiple counties for work.

The best time for me to review requests is on Friday/Saturday when I have more time to look at them, and release an update. This is why ImprovedUI Asset icon updates typically take place on Friday/Saturday. At the same time, I'm not the only person who reviews requests with Zee already adding icons this week.

Going forward, I also want to add a guide for pull requests, so you know clearly what's needed, and what you can do to speed up the process.

victor-takai commented 8 months ago

Thank you for replying and sorry for the ping.

I'm not asking you or the maintainers of the repo to rush anything, I was just curious since I saw some other pull requests from other users getting merged in short time, so that's why I asked.

I know it's been a wild week with all those patches, so thanks in advance.

logical-fallazee commented 8 months ago

For clarity: I typically work on pull requests in oldest-first order. However, class icons are much easier to test than action resource icons, so sometimes I do those first (in oldest-first order), and then action resource PRs after. Occasionally, circumstances align in which it is actually quicker and easier for me to work on one earlier than I normally would in the queue. I think you might be referring to such a situation that happened this past week: The author of the Undead race mod brought to our attention a UI bug they were consistently encountering during development. Because I was investigating that bug with the author's modfile (and determined it necessitated an IUI fix), then once I resolved the bug, it just made sense to then work on the author's action resource icon pull request because I already had their modfile loaded up.

I apologize for that, and how it must have seemed from the outside that someone was "jumping the queue". I'm sorry to have caused you worry. 🙇🏻

If there is ever anything "wrong" with a PR, we always write a comment to let the author know. ☺️ If we haven't said anything yet, it's because we haven't gotten to you yet.

(And if it's any comfort, you are (this PR is) "up next" for me to work on. ☺️☕ )

victor-takai commented 8 months ago

@logical-fallazee Oh I see what's the issue, so in the last update I added a feature to not spend point if there's no hidden treasures around to roll perception again, its probably not working properly or there's nothing to roll again, but you can use the 1.0.2.0 version from the old files section as it already has the changes related to the action resource icon and it will spend points regardless of failed events.

Download the ReRoller_Passive_Resource_1.0.2.0 file and it should be ok.

Sorry for the trouble.