It was discovered (https://github.com/TheRealDjmr/BG3ImprovedUI/issues/136#issuecomment-1953227148) that PassiveSelectors weren't showing up in levelup (progression node levels >1) if implemented as the only selector type. That is, the race tab was not becoming visible during levelup in order to choose a passive, though the "Choices Pending!" warning remained and barred players from proceeding. The race tab (and passive selection) did appear if the passive was added to CC (level 1), or if it was added in conjunction with another, [non-Passive]Selector.
Turns out this is because we erroneously left out the (sub)racial selectors from the visibility triggers for the race tab. 🤦♀️
Summary of Changes
This PR corrects the aforementioned oversight.
Bonus
I also:
renamed the collection filters from RacePassiveFeatures and SubRacePassiveFeatures to [...]Selectors for better clarity/coherence.
removed the predicate from the filters, as that has apparently also become obsolete and actually a hindrance to our intended functionality.
re-enabled the previously-functional,-at-some-point-defunct small QOL visual of the "Gained [a] Passive" preview on the race tab (in levelup) if a PassiveSelector is present. (Similar to the spell selection preview.)
removed a code block form CCLib_k.xaml that was completely unnecessary, actually. Or, perhaps, has become obsolete since its original implementation.
logical-fallazee
commented
8 months ago
Problem
It was discovered (https://github.com/TheRealDjmr/BG3ImprovedUI/issues/136#issuecomment-1953227148) that PassiveSelectors weren't showing up in levelup (progression node levels >1) if implemented as the only selector type. That is, the race tab was not becoming visible during levelup in order to choose a passive, though the "Choices Pending!" warning remained and barred players from proceeding. The race tab (and passive selection) did appear if the passive was added to CC (level 1), or if it was added in conjunction with another, [non-Passive]Selector.
Turns out this is because we erroneously left out the (sub)racial selectors from the visibility triggers for the race tab. 🤦♀️
Summary of Changes
This PR corrects the aforementioned oversight.
Bonus
I also:
RacePassiveFeaturesandSubRacePassiveFeaturesto[...]Selectorsfor better clarity/coherence.CCLib_k.xamlthat was completely unnecessary, actually. Or, perhaps, has become obsolete since its original implementation.Screenshots
Before
After