TheRealJoelmatic / RemoveAdblockThing

The intrusive "Ad blocker are not allowed on YouTube" message is annoying. This open-source project aims to address this issue by providing a solution to bypass YouTube's ad blocker detection
http://joelmatic.com/
MIT License
5.91k stars 318 forks source link

5.6 has some problems #642

Closed dfcfaaa closed 2 weeks ago

dfcfaaa commented 2 weeks ago

Script version 5.6

Describe the bug

Expected behavior It should skip ads without any problems

Screenshots If applicable, add screenshots or a video to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

bryanh-9 commented 2 weeks ago

For what it's worth, not sure if this is true universally, I have only noticed the double audio in the latest version when I open in a new tab, and let the tab load before focusing it. If that is also true for you, that is a temporary fix (go to the tab quicker, or open in current tab), and also a clue. This is consistently reproducable for me.

My guess here, is that the script destroys the old player on page load, but seemingly youtube actually creates it dynamically when you first focus the tab.

So waiting to destroy the old player until there is a focus event might be the key?

There are some other oddities, but I think it may come down to a similar issue, ie if a tab is unfocused for long enough and the browser hits memory savings, then things re-render on focus again, same issue.