TheRealSyler / vscode-sass-indented

Sass indented syntax support for VSCode
https://marketplace.visualstudio.com/items?itemName=Syler.sass-indented
Other
46 stars 8 forks source link

Some update completely broke formatting #15

Closed codysherman closed 5 years ago

codysherman commented 5 years ago

Describe the bug A lot of things broke in the latest version, it's really messing up the formatting of our files. Hard to pinpoint a specific root cause, other than to just say that it's really screwing up our file.

To Reproduce

Expected behavior It should format as before.

Screenshots If applicable, add screenshots to help explain your problem. Screenshot 2019-09-02 at 6 12 11 PM Screenshot 2019-09-02 at 6 11 25 PM Screenshot 2019-09-02 at 6 10 21 PM

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

TheRealSyler commented 5 years ago

@codysherman thanks for opening the issue, i will look into it, i might be able to publish a new version later today that addresses your issues, if not today then tomorrow.

TheRealSyler commented 5 years ago

@codysherman should be fixed, if not reopen the issue.

codysherman commented 5 years ago

Hey man thanks for the fast answer and change, but unfortunately it appears to still be broken. Now it's putting rules not tabbed in at all:

body
  color: red

becomes

body
color: red
TheRealSyler commented 5 years ago

@codysherman yeah i also just found out about it, i updated my fancy check for html tags regex and it works, the only issue is that when you have a tag without any other stuff attached to it, the regex fails, the fix for know is use ///R it sets the indenation level.

body
  ///R
  color: red
  // everything until the next selector will be indented based on the indentation of ///R  

it will be fixed in the next version but im not going to update until i change more stuff.