TheRealSyler / vscode-sass-indented

Sass indented syntax support for VSCode
https://marketplace.visualstudio.com/items?itemName=Syler.sass-indented
Other
44 stars 8 forks source link

@functions isn't recognized by TM Scopes. Name of @import is no longer a string #27

Closed Limonische closed 4 years ago

Limonische commented 4 years ago

Describe the bug If you try to inspect @function statement with "Inspect TM Scopes" it freezes in infinite loading. Color highlighting for @function is broken. Same goes for mixins. Name of file in @import is no longer a string.

To Reproduce Use "Inspect TM Scopes" in vscode-insiders 1.41.0

Expected behavior Color highlighting for @function should work, it also should be accessible by "Inspect TM Scopes". Same for mixins. Name of file in @import statement should be a string.

Screenshots image

@function strip-unit($value)
    @return $value / ($value * 0 + 1)

@function get($map, $keys...)
    @each $key in $keys
        $map: map-get($map, $key)
    @return $map

image

=media($width...)
    @if length($width) == 1
        @media screen and (min-width: nth($width, 1))
            @content
    @if length($width) == 2
        @media screen and (min-width: nth($width, 1)) and (max-width: nth($width, 2))
            @content

image

@import 'imports/imports'

Desktop (please complete the following information):

TheRealSyler commented 4 years ago

@Limonische the highlighting is already fixed in the latest version (on my local machine), not sure what "Inspect TM Scopes" is but ill look into it.

Limonische commented 4 years ago

Its a feature in vscode that allows you to look at language token types and detect which colors and styles are applied to it. You can access it by ctrl/command + shift + p and then selecting "Developer: Inspect TM Scopes" image

Thank you for your fast reply.

TheRealSyler commented 4 years ago

yeah just downloaded vscode insiders its a really cool feature, it should already be fixed, the reason why the highlighting doesn't work is this regex [[\\w-]+ as you can see the regex is invalid i catched that shortly after publishing

Limonische commented 4 years ago

Thank you again! Can i ask you when this new release with fixes will be shipped?

TheRealSyler commented 4 years ago

im not sure i will try to have it published tomorrow or the day after that.

Limonische commented 4 years ago

Nice. Keep your good work :)

TheRealSyler commented 4 years ago

@Limonische hey if you want it fixed right now, go to this repo and download sass-indented-1.6.8.vsix then search for the install.vsix extension, right click on the file and chose install extension, you might need to download the entire repo because i don't think that github lets you download single files.

TheRealSyler commented 4 years ago

also not sure if it auto updates extensions after you install them from a file so you might need to uninstall and reinstall the extension when the new version comes out.