TheRemover / fail2ban-aws-nacl

AWS Network ACL Fail2ban Script
8 stars 2 forks source link

Consolidate nacl_list #3

Open brokensound77 opened 7 years ago

brokensound77 commented 7 years ago

I see that there are some functions which are reused across both py files. Why not eliminate the main within the nacl_list.py and import the entire file into the primary aws_nacl file.? This allows you to maintain the cleanliness of the code, especially since you are maintaining consistent namespace and allows you to:

TheRemover commented 7 years ago

This script originally started out as only a fail2ban action script but has grown based on other requirements.

nacl_list.py is for searching for an internal IP address across all regions and printing the ACL associated with the instance. Since some of the functions are duplicated it could be combined and called via a CL parameter. I will create a new branch to integrate.