TheRenegadeCoder / image-titler

An image title generator using The Renegade Coder style

https://therenegadecoder.com

GNU General Public License v3.0

17 stars 6 forks source link

Made GUI Consistent with CLI #67

Closed jrg94 closed 4 years ago

jrg94 commented 4 years ago

I have officially updated the GUI end of the software to support a consistent command line interface with the CLI tool. In other words, users can now prepare their GUI interface with a command, so they don't have to load up the usual settings by hand. This fixes #51.

Also, this fixes all of the following:

Fixes #51 (consistent CLI/GUI commands)
Fixes #66 (custom fonts don't all show up)
Fixes #62 (work through keyword arguments)
Fixes #44 (-t works for batch)
Fixes #69 (default batch setting)

jrg94 commented 4 years ago

I made some MAJOR rework in this pull request. Honestly, this should probably become a new major version. That said, I still need to go back and pretty much rewrite all testing now that everything is properly decoupled.

codecov-io commented 4 years ago

Codecov Report

Merging #67 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files           6        6           
  Lines         451      451           
=======================================
  Hits          447      447           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1795e8e...1795e8e. Read the comment docs.

jrg94 commented 4 years ago

Everything is in very good shape! I just need to add more support for command line arguments on the GUI end. Then, we'll be good to go!

jrg94 commented 4 years ago

Code appears to be in good shape now! I think tomorrow morning I'll take one last look before merging.

jrg94 commented 4 years ago

BEFORE I MERGE THIS! I need to remember to actually test the package. Also, I'll need to update READMEs and whatnot. For instance, I'll need to make a note that the CLI is as bare bones as it gets now. No show. No prompt. I want to shift any interaction possible to the GUI.

jrg94 commented 4 years ago

One last thing. I think the indexing mechanic needs to be removed unless a title is used in batch mode.

jrg94 commented 4 years ago

Last thing left is to test the package. I need to make sure that the images are getting include.

jrg94 commented 4 years ago

I think this is good to go!