search

TheRenegadeCoder / image-titler

An image title generator using The Renegade Coder style
https://therenegadecoder.com
GNU General Public License v3.0
17 stars 6 forks source link

Fixed Trailing Spaces Bug #83

Closed jrg94 closed 4 years ago

jrg94 commented 4 years ago

Fixes #80

There was a nasty bug where custom titles could result in empty space on either end of the title. A strip command was added right at the point the overlay is generated. As a result, the data that's passed around goes unchanged, AND the extra spaces don't affect the splitting of the text. This was the best solution I could come up with without doing some sort of data cleaning on the input. Now, a user can enter a bad title, and it will have no effect on either the GUI or Command Line solutions.

codecov-commenter commented 4 years ago

Codecov Report

Merging #83 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   99.19%   99.20%           
=======================================
  Files           6        6           
  Lines         498      504    +6     
=======================================
+ Hits          494      500    +6     
  Misses          4        4
Impacted Files Coverage Δ
imagetitler/draw.py 100.00% <100.00%> (ø)
imagetitler/tests/test_utilities.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6fc4e2e...ace8d87. Read the comment docs.