search

TheRoddyWMS / BatchEuphoria

A library to access different kinds of cluster backends
MIT License
3 stars 5 forks source link

Remove daemon, improve tests, add tests, fix bugs #137

Open dankwart-de opened 5 years ago

vinjana commented 1 year ago

@coderabbitai review

coderabbitai[bot] commented 1 year ago

Walkthrough

The changes primarily revolve around the refactoring and enhancement of the job management system in a Gradle-based project. The job management system has been updated to use ExtendedJobInfo and JobInfo classes instead of the deprecated GenericJobInfo and JobState classes. The Gradle version has been upgraded, and the JVM heap size has been increased. Additionally, several new test cases have been added to verify the updated functionalities.

Changes

File(s) Summary
build.gradle Added dependencies on Jackson libraries and updated the dependency on RoddyToolLib.
gradle/wrapper/gradle-wrapper.properties Upgraded Gradle version from 4.8 to 5.1.1.
gradlew, gradlew.bat Increased JVM heap size to 64 megabytes.
src/main/groovy/de/dkfz/roddy/config/ResourceSet.groovy Added @EqualsAndHashCode annotation to the ResourceSet class.
src/main/groovy/de/dkfz/roddy/execution/jobs/BEFakeJobID.groovy, src/main/groovy/de/dkfz/roddy/execution/jobs/BEJobID.groovy Updated inheritance of BEFakeJobID and removed deprecated FakeJobID class.
src/main/groovy/de/dkfz/roddy/execution/jobs/BatchEuphoriaJobManager.groovy Made extensive changes including removal of deprecated methods and variables, and introduction of new methods.
src/main/groovy/de/dkfz/roddy/execution/jobs/ExtendedJobInfo.groovy, src/main/groovy/de/dkfz/roddy/execution/jobs/JobInfo.groovy Introduced new classes ExtendedJobInfo and JobInfo to store job information.
src/main/groovy/de/dkfz/roddy/execution/jobs/JobManagerOptions.groovy Updated several variables and their default values.
src/main/groovy/de/dkfz/roddy/execution/jobs/QueryJobStatesFilter.groovy Introduced a new class QueryJobStatesFilter.
src/main/groovy/de/dkfz/roddy/execution/jobs/SubmissionCommand.groovy Removed deprecated toString() method.
src/main/groovy/de/dkfz/roddy/execution/jobs/cluster/... Made various changes to job manager classes, including method updates, new method additions, and import changes.
src/test/groovy/de/dkfz/roddy/batcheuphoria/BETestBaseSpec.groovy Added a new base class for Spock specs.
src/test/groovy/de/dkfz/roddy/execution/jobs/BEIntegrationTest.groovy Updated test cases to use new job information classes and methods.
src/test/groovy/de/dkfz/roddy/execution/jobs/... Added and updated various test classes and cases to verify the updated job management functionalities.
src/test/resources/de/dkfz/roddy/... Added and updated various test resources.
Tips ### Chat with CodeRabbit Bot (`@coderabbitai`) - If you reply to a *review comment* from CodeRabbit, the bot will automatically respond. - To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment - Note: Review comments are made on code diffs or files, not on the PR overview. - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai help` to get help. - `@coderabbitai resolve` to resolve all the CodeRabbit review comments. Note: For conversation with the bot, please use the review comments on code diffs or files. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json`