TheRoddyWMS / BatchEuphoria

A library to access different kinds of cluster backends
MIT License
3 stars 5 forks source link

Use BashConverter / a Service to convert commands to the target system #97

Closed dankwart-de closed 6 years ago

dankwart-de commented 6 years ago

I think this is tightly related to the converters in RoddyToolLib or? In any case, we need to discuss and improve this. The current code to convert a command looks like:

 RoddyCore/src/de/dkfz/roddy/execution/io/ExecutionService.groovy
 @@ -6,7 +6,6 @@

  package de.dkfz.roddy.execution.io

 -import de.dkfz.roddy.config.converters.BashConverter
  import de.dkfz.roddy.config.loader.ConfigurationLoaderException
  import de.dkfz.roddy.execution.BEExecutionService
  import de.dkfz.roddy.execution.jobs.Command
 @@ -181,7 +180,7 @@ abstract class ExecutionService implements BEExecutionService {
          String cmdString
          if (!configurationDisallowsJobSubmission && !allJobsBlocked && !pidIsBlocked && !preventCalls && !isDummyCommand) {
              try {
 -                cmdString = command.toString()
 +                cmdString = command.toBashCommandString()
vinjana commented 6 years ago

out of scope