TheRoddyWMS / Roddy

The Roddy workflow development and management system.
http://roddy-documentation.readthedocs.io
MIT License
8 stars 3 forks source link

Work out correct escaping of configuration variables in parameter file #220

Open vinjana opened 6 years ago

vinjana commented 6 years ago

Configuration variables need to be passed through a shell-layer at different places in Roddy, e.g. in the wrapInScript.sh if when commands are remotely or locally executed.

The current approach to just use double quotes for configuration values (with some exceptions) is not ideal and results in misconfigurations. A better way needs implemented

Continue these thoughts, and come up with a disciplined way for quoting and escaping that works and is simple enough for the users.

vinjana commented 6 years ago

Compare RoddyToolLib:bash-services (6e79d18).

vinjana commented 6 months ago

There is a reimplementation of the scaping logic that might be useful. See RoddyToolLib::RoddyIOHelpers.EscapableString, or consider using Apache Commons Text StringUtils.