search

TheRoddyWMS / Roddy

The Roddy workflow development and management system.
http://roddy-documentation.readthedocs.io
MIT License
8 stars 3 forks source link

Implement an existing templating mechanism for ConfigurationIssueLevel and rework the messages. #310

Open dankwart-de opened 6 years ago

dankwart-de commented 6 years ago

vinjana 6 days ago Member

See comment in tests. Maximize information / character ratio. @npeschke npeschke 7 hours ago Member

I get this warning for the cvalues RODDY_JOBID, RODDY_JOBNAME, RODDY_QUEUE, scratchBaseDirectory and RODDY_SCRATCH which are not in direct control of the user. Therefore, it might be beneficial to either omit them from checking or rework the check to minimize users getting worried about the warning when running a job.

It might also be helpful to give a quick summary of the affected cvalues like

The values A, B, C in your configuration...

@vinjana vinjana 3 hours ago Member

Yes, these values should not get warnings. The second option you propose I do not understand, but certainly users should not get worried unnecessarily. @dankwart-de dankwart-de just now Member

You are right and I'd like to change it. However, I'd like to postpone the changes and implement them together with a templating engine/mechanism (see below). I'll create an issue for it.

vinjana commented 5 years ago

See https://github.com/TheRoddyWMS/Roddy/pull/307 for the original discussion.