search

TheRoddyWMS / Roddy

The Roddy workflow development and management system.
http://roddy-documentation.readthedocs.io
MIT License
8 stars 3 forks source link

Clean up bash escaping #375

Open vinjana opened 1 year ago

vinjana commented 1 year ago

Currently, there are multiple places in which shell commands are prepared for execution by quoting or escaping. At least there are

This code is then used in BatchEuphoria and Roddy to do shell-escaping. And both approaches are probably leaky and certainly not portable.

Clean this up. Either use escaping or (proper) quoting (the current implementation is simplistic).

One option is to use Apache Commons Text.

vinjana commented 6 months ago

As far as possible, replace all usages of the named classes by either Apache Commons Text StringUtils, or use RoddyToolLib EscapableString.