search

TheRoddyWMS / Roddy

The Roddy workflow development and management system.
http://roddy-documentation.readthedocs.io
MIT License
8 stars 3 forks source link

Improve and check error messages, when the i/o parameter count does not match the calls input. #84

Open dankwart-de opened 7 years ago

vinjana commented 7 years ago

@dankwart-de Can you explain this a bit better? Maybe with an example?

dankwart-de commented 6 years ago

Sometimes, you e.g. redefine a tool and forget a parameter or you forget to set a parameter in code. Then a mismatch can occur. But: IMO Roddy should be hard then and stop working. @vinjana ?

vinjana commented 6 years ago

So

  1. Forget to define a parameter in the XML. Roddy could only know about this by looking at the parameters in the JVM code and then report a "missing parameter in XML" error.
  2. Forget to define a parameter in the JVM code. Roddy could only know about this by looking at the parameters in the XML and then report a "missing parameter in JVM" error.

Is this what you mean?

vinjana commented 6 years ago

This does not refer to a simple test of the number of parameters, but really means that all parameters in the JVM and XML codes need to be identical and set!

vinjana commented 6 years ago

What about type checks? Both XML and Java code also have type declarations, which could also get checked.

dankwart-de commented 6 years ago

Type checking is already supposed to be working. We need to add tests for it. It might actually be, that it is not working.

Am 11. Juli 2018 15:15:12 schrieb Philip Reiner Kensche notifications@github.com:

What about type checks? Both XML and Java code also have type declarations, which could also get checked. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.