search

TheRusskiy / ng-slide-down

AngularJS directive for slide-down animation
41 stars 16 forks source link

Doesn't work for tables #17

Closed Bouzmine closed 8 years ago

Bouzmine commented 8 years ago

I'd like to be able to use this directive in conjonction with a table but it's not working. Tables doesn't accept height:0;.

TheRusskiy commented 8 years ago

can't you wrap your table in div?

Bouzmine commented 8 years ago

Thanks for the fast answer, I do know it's possible to wrap table in divs for the table to behave as a div but I'd like the directive to detect when it's applied to a table and wrap it in a div (if that's not too much to ask). Otherwise, thanks for this useful piece of software.

TheRusskiy commented 8 years ago

I've done a breaking change, now all content is wrapped into divs https://github.com/TheRusskiy/ng-slide-down/commit/dae8506af9fc7cba125d5008cee075d379f71d79

Bouzmine commented 8 years ago

Thanks, I can't wait to try it out.