TheSainEyereg / flipper-pc-monitor

Flipper Application for monitoring PC state
MIT License
55 stars 0 forks source link

BT Serial logging is obsolete in new versions (not able to compile for new FW) #3

Open vollukas opened 7 months ago

vollukas commented 7 months ago

To make it work on new FW you need to fix BT serial logging or comment it out (it's only for development purposes only).

I got it working on latest XFW dev branch so I can make pull request with commented code.

TheSainEyereg commented 7 months ago

I got it working on latest XFW dev branch so I can make pull request with commented code.

That would be great. I don't have much time to maintain my Flipper Zero projects, so I'm open for any PRs

vollukas commented 7 months ago

I found out the code wasn't for debugging but for initializing BT connection :D it's a small change but I'm struggling to find the correct new methods to use instead of furi_hal_bt_serial_set_event_callback()...

It still works on most older FW so it wouldn't be good to just merge this fix into master... I'll keep finding the fix and maybe create a new branch with it or something :D can I add you on discord or somewhere?

Willy-JL commented 7 months ago

https://github.com/Flipper-XFW/Xtreme-Apps/commit/4b11f0363498461b13efbfcbc6f4b43fd7904554

Willy-JL commented 7 months ago

uses a separate BLE profile. needs pairing again, and must pair after opening PC Monitor app. actually now that i think about it, this should also store pair database in separate file...

Willy-JL commented 7 months ago

https://github.com/Flipper-XFW/Xtreme-Apps/commit/59ebc5ba9ad84c247c614f17f2d3234241b4c931

vollukas commented 7 months ago

Willy fixed it quite nicely but the backend needs some more modifications. Gonna search connection with "PC mon" string so it won't spam pairing prompts all the time. I will probably do it so you first hit enter or manually enter different prefix and then hit another enter or manually set name of your flipper.