TheScienceMuseum / collectionsonline

Science Museum Group Collection Online
https://collection.sciencemuseumgroup.org.uk
MIT License
47 stars 3 forks source link

Odd behaviour with object filters #420

Closed jamieu closed 8 years ago

jamieu commented 8 years ago

Apologies if this is already fixed, but seeing some odd behaviour with the object types filter.

If you select 'poster' and then 'aeroplanes' I'd expect all "posters of aeroplanes" (ie. objects with both those values) and those two checkboxes to remain checked. The only other values shown at that point would be a third (or more) tag assigned to objects in the result set, whose first and second tag was "posters" and "aeroplanes".

screen shot 2016-10-03 at 18 08 53 screen shot 2016-10-03 at 18 09 07
Danwhy commented 8 years ago

So this works with the 'material' filters, we just need to apply that same logic to the others. Should be quite a simple fix

jamieu commented 8 years ago

Here is another example,

1) User selects: [x] therapeutics [injection] 221

2) You'd now expect to see everything filtered by therapeutics [x] therapeutics [injection] 221 [] hypodermic syringes 186 [] bottle 1 [] syring 1

2) User now selects 'hypodermic syringes' you'd expect to see both 'hypodermic syringes' and "therapeutics " checked with the remaining values reflecting objects that have a 3rd tag. [x] therapeutics [injection] 221 [x] hypodermic syringes 186 [] bottle 1 [] syring 1

In short the filter values should reflect the result set to the left, for all filters except 'on display' and 'image use/licence'.

See #244

screen shot 2016-10-05 at 13 04 34 screen shot 2016-10-05 at 13 04 28 screen shot 2016-10-05 at 13 04 21
jamieu commented 8 years ago

Fixed 👍