search

TheSeamau5 / elm-check

Property Based Testing in Elm
70 stars 20 forks source link

Update code and dependencies for Elm 0.16 #28

Open Janiczek opened 8 years ago

Janiczek commented 8 years ago

This will probably transitively propagate to other packages such as elm-random-extra.

rtfeldman commented 8 years ago

@TheSeamau5 is this on your radar? Would be happy to make a PR for it. :smiley:

mgold commented 8 years ago

+1, this is blocking my nonempty list library.

Actually Hassan seems to have been out for months. But I see Richard's company has forked everything and updated it. Thanks! https://github.com/NoRedInk/elm-check/tree/1.0.0

Janiczek commented 8 years ago

Awesome!

mgold commented 8 years ago

Except I still couldn't get it to work because of the Elm-Check dependency?

rtfeldman commented 8 years ago

@mgold updating the elm-check fork is blocked on updating the elm-random-extra fork, as some breaking Core changes to Random in 0.16 make for a nontrivial upgrade path there.

mgold commented 8 years ago

Okay I'll look into that.

mgold commented 8 years ago

Done: NoRedInk/elm-random-extra#1

TheSeamau5 commented 8 years ago

Hey guys, I'm really sorry for disappearing. I've had a lot on my plate these past few months and I can't believe how it has really kept me from doing any programming. I'm glad you guys have forked this library and I'm really sorry for not warning you guys. I hope everything works out now. Hopefully now I finally have some time to do some programming, so you might see me helping around a little nowadays.

rtfeldman commented 8 years ago

Great to see you again @TheSeamau5! :smiley_cat: :tada: :grinning:

mgold commented 8 years ago

:tada: :smile: Welcome back! The plan is to move these libraries to elm-community when 0.17 comes around. It would be great to move the base fork, and then replay the NoRedInk changes on top of it.

TheSeamau5 commented 8 years ago

Thank you so much guys. I see. I don't know how to move the base fork, so just tell me how to do it when the time comes and I'll do it,

mgold commented 8 years ago

It's under settings somewhere, and yes we'll get your attention when the time comes. (By "base fork" I mean the original, unforked repo, which is to say yours and not NoRedInk's.)