Move service description lower

homeyjd commented 10 years ago

When service is in error state, system will attempt to restart vsftpd before updating /etc/vsftpd.conf. Chef will forever fail. Updated recipes/_configure.rb to put service description below template calls. The "notifies" directive still works correctly as it appears the string 'service[vsftpd]' is resolved during the run-phase instead of compile-phase.

homeyjd commented 10 years ago

For reference, I have only tested this against edge Chef v11.8.2.

TheSerapher commented 10 years ago

That's strange. Will try this out myself since this does not look like an expected behaviour.

TheSerapher commented 10 years ago

I setup a test kitchen box with the following:

Provisioner: chef_solo
Chef Client: 11.8.2

The converge ran successfully without any errors:

[...]
       [2014-11-04T09:46:43+00:00] INFO: Chef Run complete in 40.274098378 seconds
       [2014-11-04T09:46:43+00:00] INFO: Running report handlers
       [2014-11-04T09:46:43+00:00] INFO: Report handlers complete
       Chef Client finished, 10 resources updated
       Finished converging <default-centos-70> (1m20.21s).
[...]

Any more details on this issue? I ran an entire converge across all platforms and all converge runs ended successfully. Even a second run did not throw any errors.

homeyjd commented 10 years ago

Wow, thanks for getting to this so quickly. My action steps that produced the error:

use recipe to install vsftpd (months ago) OS: CentOS 6.5
... Time to upgrade! * upgrade Chef version to 11.8.2 * upgrade vsftpd RPM to latest: vsftpd-2.2.2-13.el6_6.1.x86_64 (probably overwrote /etc/vsftpd/vsftpd.conf and others)
vsftpd now fails to start In my case, there seemed to be a config conflict. Service-start sudo service vsftpd start would fail as would sudo vsftpd. Both would exit status=1 without any syslog or file log messages. Never did find the exact issue though the upgrade broke 2 systems -- very frustrating.
run Chef to fix the problem When Chef reaches the run-phase of the vsftp::_configure recipe, the service has been defined before the template calls have been. This means that the action => :enable, :start will take effect first, THEN the vsftpd.conf (and other configs) will be updated, THEN vsftpd will be reloaded.
Chef fails because the service cannot start with current configuration

TheSerapher commented 9 years ago

Sorry I totally forgot to merge this one! My bad :-/

TheSerapher / chef-vsftpd

Move service description lower #10