Pull Request : Add SSL support

TheSerapher / chef-vsftpd

Basic vsftpd cookbook to manage local users FTP access.

Apache License 2.0

13 stars 28 forks source link

Pull Request : Add SSL support #15

Closed Gazzonyx closed 8 years ago

Gazzonyx commented 9 years ago

I ended up not actually needing this, but someone else might want it, so I'm throwing this code over the wall. One thing to note is that this adds a dependency on the openssl cookbook. Not sure if that's a deal-breaker or not.

TheSerapher commented 9 years ago

Quick question:

Should it be enabled by default?
Only self-signed supported?

Good idea though, maybe we can expand the support to full certificates :-)

TheSerapher commented 9 years ago

And check the build errors and fix as required :-)

Gazzonyx commented 9 years ago

So, funny story. I needed an SFTP server setup and for whatever reason it didn't occur to me, until right after I added the signed cert, that I was building an FTPS server. :)

I'll add full-ish support for SSL, fix those build errors and send a new pull request later today or tomorrow. The on-by-default thing was actually just something that didn't get sanitized from my internal cookbook when I committed - I'll fix that as well.

Do you have a preference if I close this PR and open a new one or just commit over this open one?

TheSerapher commented 9 years ago

Feel free to update this one :-)

Gazzonyx commented 9 years ago

Just a heads up, this is still on my radar but I've got a fire to put out at work, so it'll probably get done during the weekend.

Gazzonyx commented 9 years ago

I've still got to write some integration tests, but how does commit https://github.com/Gazzonyx/chef-vsftpd/commit/906dc73d524d76bf2b7a99d94f7b576599c68541 strike your fancy?

TheSerapher commented 9 years ago

That looks pretty good!

TheSerapher commented 8 years ago

Completely forgot about this, so sorry.