TheSil / WhoracleMod

Fork of OpenJK aimed at fixing bugs and improving gaming experience.
GNU General Public License v2.0
1 stars 0 forks source link

Non-existent sound files causing bug with final obj completion sound in Siege #11

Closed deathsythe47 closed 8 years ago

deathsythe47 commented 8 years ago

See https://github.com/TheSil/base_enhanced/issues/93

These files are referenced by the .siege files for the base maps. They do not actually exist; maybe they were left out of the JK3 release to save space on the CD? Who knows. Since the client game attempts to play them, it therefore does not play the "obj complete" sound for the final objective, which was initiated immediately beforehand.

A quick, hacky fix for this would be to ignore roundover_sound_wewon and roundover_sound_welost if they match any of those filenames listed above.

A more elegant solution would be to check in the roundover_sound_wewon and roundover_sound_welost code to see if the file itself exists before attempting to play it.