Bug with g_siegeteam1 / g_siegeteam2 override

[deathsythe47]

g_siegeteam1 and g_siegeteam2 are intended to let you override the siege teams(classes) specified in the .siege file:

        if (g_siegeTeam1.string[0] && Q_stricmp(g_siegeTeam1.string, "none"))
        { //check for override
            strcpy(team1, g_siegeTeam1.string);
        }
        else
        { //otherwise use level default
            BG_SiegeGetPairedValue(teams, "team1", team1);
        }

However, there is a glitch, and as a result, nobody has ever been able to use these bugged cvars. Something between server and client doesn't work properly.

Steps to replicate:

• Load a siege game normally (g_siegeteam1 none and g_siegeteam2 none)
• Connect to the server
• Set one or both of the cvars, for example, g_siegeteam1 Siege4_Imperial
• Restart the map
• You are still using the old classes; nothing changed
• Press escape key, and click "join"
• You get disconnected from the server with error message "error loading teams in UI"
• Try to reconnect
• You cannot reconnect, and instead you get the error message "No team entry for Siege4_Imperial"