search

TheSilentPro / HeadDB

Provides access to a database of over 100k heads
GNU General Public License v3.0
24 stars 21 forks source link

Hide the Favorites, Search and Local UI options based on permissions. #10

Closed ghost closed 3 years ago

ghost commented 3 years ago

This is a small change, because I very much dislike players seeing the options for Favorites, Search and Local only to be rejected because they don't have the permission.

The Search UI option uses a new permission, headdb.searchui in order to keep the /hdb search command in servers where the UI errors out. This is the case in my Paper 1.17 server, where /hdb search works fine, but clicking on the Search UI item results in an error.

TheSilentPro commented 3 years ago

If the GUI errors while trying to open search using the item in the menu on 1.17 I'd much rather fix that than have two separate permissions. I haven't gotten around to testing it on newer versions though, can you paste the error?

ghost commented 3 years ago

The error is on AnvilGUI, it does not support 1.17. I opened a new issue for it, but I think it's out of your hands until they update: https://github.com/TheSilentPro/HeadDB/issues/11

ghost commented 3 years ago

I have added a commit to this PR in order to use the existing headdb.search permission, and will instead keep a separate branch in my personal repository for 1.17 until AnvilGUI is updated.