search

TheSoundOfAIOSR / project_common

Common environment for all groups to connect to other groups with a relative path
MIT License
9 stars 5 forks source link

sound_gen venv now created in root directory #16

Closed Leofltt closed 3 years ago

Leofltt commented 3 years ago

The environment for sound gen was being created inside the timbre conditioned VAE instead of the root directory of the repo, creating conflicts on run (basically the run script was looking for an env in root, but I was installing the env in timbre_conditioned_vae ... ooops!). Now it's created in the root directory of rg_sound_generation to be more consistent with all the other rgs and not fail to run

am1tyadav commented 3 years ago

@Leofltt I think it will make more sense if the contents of timbre_conditioned_vae were in the top dir in the rg_sound_generation repo, right? I can refactor it so and it will become more consistent with other repos. Let me know if that makes sense and I will make the changes

Leofltt commented 3 years ago

@am1tyadav are you saying to just move the requirements outside of timbre_conditioned_vae? The problem with the merge before this one is that I was installing the env within the rg_sound_generation/timbre_conditioned_vae, while the run script is looking for an env in rg_sound_generation. This commit fixes it installing the env in the proper place. If you want to change something on your end feel free to do so, but my point is: this works without having to change the run script on the sound generation repo

am1tyadav commented 3 years ago

are you saying to just move the requirements outside of timbre_conditioned_vae?

Requirements as well as all the scripts inside that folder can be moved to rg_sound_generation/

Because, if im not mistaken, you still need to enable env from rg_sound_generation/ but then cd into timbre_conditioned_vae/ to run the main_rgws script

Leofltt commented 3 years ago

"Because, if im not mistaken, you still need to enable env from rg_sound_generation/ but then cd into timbre_conditioned_vae/ to run the main_rgws script" -> This is precisely how the run script is setup right now it looks like. If you want to move the reqs outside, feel free to do the necessary modifications on this file (setup_mac.sh) and on your end in the sound_generation repo and only keep the main_rgws.py inside timbre_conditioned_vae as to not break the run script. Whatever you prefer works for me!

Leofltt commented 3 years ago

@am1tyadav also another heads up on this file line 20 should be changed to cd .. and not cd ../... Man I sure am sloppy at this thing ahahahah

am1tyadav commented 3 years ago

@Leofltt Let me merge this then and make some changes on top :)