TheSoundOfAIOSR / project_common

Common environment for all groups to connect to other groups with a relative path
MIT License
9 stars 5 forks source link

fix for #53 on the Mac side #54

Closed Leofltt closed 2 years ago

Leofltt commented 2 years ago

Portaudio was not listed as a dependency and only installed automatically on windows, not on mac. Added documentation and modified mac script. We should do the same for Linux eventually

Leofltt commented 2 years ago

I also added an extra setup script for mac that runs with python3.8 installed as python3.8 rather than python3, makes life easier for some testers

wassfila commented 2 years ago

Why do we no longer go through the dev first ? That would not require many reviews. This direct merge is also ok, just make sure nothing is forgotten on the dev. Ok, dev branch no longer there so no problem.

Leofltt commented 2 years ago

Why do we no longer go through the dev first ? That would not require many reviews. This direct merge is also ok, just make sure nothing is forgotten on the dev. Ok, dev branch no longer there so no problem.

Kind of too cumbersome to have to do 4 reviews for what is mostly a documentation change really. Also have some people who are currently testing this now needed to push it quickly. I can rebase dev

wassfila commented 2 years ago

Why do we no longer go through the dev first ? That would not require many reviews. This direct merge is also ok, just make sure nothing is forgotten on the dev. Ok, dev branch no longer there so no problem.

Kind of too cumbersome to have to do 4 reviews for what is mostly a documentation change really. Also have some people who are currently testing this now needed to push it quickly. I can rebase dev

I'm fine with that, maybe in this late stage we no longer need the dev, or keep it only for risky stuff.

Leofltt commented 2 years ago

I think we could close dev and create feature branches on purpose if we need to do major updates. For bug fixes / submodule updates that have already been also going through review process within the submodule itself before MR, the three reviews should suffice