search

TheSpaghettiDetective / OctoPrint-Obico

GNU Affero General Public License v3.0
138 stars 42 forks source link

[BUG] Minor documentation error? Compatible mode doesn't preserve fps #172

Open puterboy opened 2 years ago

puterboy commented 2 years ago

The documentation (https://www.obico.io/docs/user-guides/webcam-streaming-resolution-framerate/) says:

When the webcam streaming is in "Basic" mode, or "Premium (compatibility)" mode, The Spaghetti Detective plugin won't change the resolution or the frame rate. Instead, they are set by the OctoPrint's original streaming process before The Spaghetti Detective plugin was installed.

However, in compatible mode the routine ffmpeg_from_jmpeg sets fps to 25 (for pro) or 5 for non-pro. Now the underlying content will still be based on 5 fps but the stream will presumably be interpolated up/down to 25 or 5 fps.

Which begs the question, why not match the frame rate of the camera (subject to maximum of 25/5)?

Presumably, one can determine the raw frame rate by using 'ffmpeg -i stream_url' and then set the fps to that number subject to any subscription caps.

kennethjiang commented 2 years ago

Good catch. I'll probably defer fixing the doc since we will soon change how Obico streaming handles the resolution and framerate.