search

TheSpaghettiDetective / moonraker-obico

GNU Affero General Public License v3.0
149 stars 41 forks source link

[BUG] S99moonraker_obico needs to be renamed to work with moonraker svc #103

Closed jynolen closed 1 month ago

jynolen commented 4 months ago

Describe the bug The way supervisorctl is done on Creality K1 is by checking the pid based on init.d filename.

ie. if the is named S17-fooooooo_baaarrrr the supervisorctl will assume a pid file named fooooooo_baaarrrr.pid

Even if another pid is setup within the init;d file.

Since in "S99moonraker_obico" the pid is moonraker-obico.pid the filename should be renamed accordinly (or pid file must match with underscore)

kennethjiang commented 3 months ago

Sorry for the delay.

I'm not sure if I understand your point here, probably because I'm not super familiar with how supervisorctl. I made the service script to a point that it seems to have worked. But it's possible it has some other flaws.

Maybe you can re-phrase your point so that I can understand what is impacted by this issue? Or maybe you can submit a PR to fix it? I think I will understand it better if I can see how you'd fix it.