TheSpaghettiDetective / moonraker-obico

GNU Affero General Public License v3.0
149 stars 41 forks source link

Create ~/klipper_logs if it doesn't exist #14

Closed mylesagray closed 2 years ago

mylesagray commented 2 years ago

After installation, the systemd unit will fail to start if the directory for logs doesn't exist, as soon as it's created it runs successfully.

Maybe a handler for creating the folder for logs if it doesn't exist would be a good addition?

crashmaxx commented 2 years ago

I agree making the directory if it doesn't exist is a good addition. Shouldn't be hard to add.

I'm curious though. Did it prompt you to input the log directory when you installed it? Did you go with the default even though your klipper logs are in a different place?

mylesagray commented 2 years ago

No from what I remember there was no prompt so I just went with the defaults.

I use MainsailOS as my distro, and it doesn’t have a ~/klipper_logs folder, so only after digging through journalctl did I find out that’s what it was trying to do.

Sent from mobile

On 9 Feb 2022, at 01:25, crashmaxx @.***> wrote:

 I agree making the directory if it doesn't exist is a good addition. Shouldn't be hard to add.

I'm curious though. Did it prompt you to input the log directory when you installed it? Did you go with the default even though your klipper logs are in a different place?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

crashmaxx commented 2 years ago

15 created to make sure the log directory exists when installing.

encetamasb commented 2 years ago

15 created to make sure the log directory exists when installing.

Merged. Thank you!