TheSpaghettiDetective / moonraker-obico

GNU Affero General Public License v3.0
149 stars 41 forks source link

Minor documentation error? Compatible mode doesn't preserve fps #32

Closed puterboy closed 2 years ago

puterboy commented 2 years ago

The documentation (https://www.obico.io/docs/user-guides/webcam-streaming-resolution-framerate/) says:

When the webcam streaming is in "Basic" mode, or "Premium (compatibility)" mode, The Spaghetti Detective plugin won't change the resolution or the frame rate. Instead, they are set by the OctoPrint's original streaming process before The Spaghetti Detective plugin was installed.

However, in compatible mode the routine ffmpeg_from_jmpeg sets fps to 25 (for pro) or 5 for non-pro. Now the underlying content will still be based on 5 fps but the stream will presumably be interpolated up/down to 25 or 5 fps.

Which begs the question, why not match the frame rate of the camera (subject to maximum of 25/5)?

Presumably, one can query using 'ffmpeg -i stream_url'

puterboy commented 2 years ago

Moved to https://github.com/TheSpaghettiDetective/OctoPrint-Obico/issues/172