TheSpyder / SyncedSideBar

Sublime Text plugin to sync project sidebar (folder view) with currently active file.
341 stars 23 forks source link

Ignore file patterns when provided via setting #64

Open mataha opened 1 year ago

mataha commented 1 year ago

This PR adds an option to ignore file patterns when provided via the reveal-ignore-patterns setting requested in #50, which I'd imagine shows its usefulness when working in an environment with in-project dependencies (e.g. Node.js with node_modules or Python with venv). The list is by default empty.

ebebc73 is the commit that adds the feature; 11fb69f fixes most of the obnoxious linter/formatter errors (semicolons, extra newlines, long LoC and such).

TheSpyder commented 1 year ago

I appreciate you putting effort into this - and fixing the code format, too, I don't develop this plugin much anymore so the code style is quite old.

I'll try to find time to review it over the weekend.

mataha commented 1 year ago

I'd like to do a bit more (namely modernize the code a bit and respect files such as .gitignore), but that would mean dropping support for Sublime <4050 (in order to run the plugin using Python 3.8 to take advantage of some newer features).

That said, some parts of the code are for backward compatibility with Sublime Text 2... how many years has it been?

TheSpyder commented 1 year ago

I took over the plugin during the ST2 days, and the old code never seemed to cause a problem so I left it in 😂

It looks like version-specific Package Control deployment is easy, so I can just tag the current version and have the master branch continue with ST >4050. https://github.com/wbond/package_control_channel/blob/d3ffb6f926739c0ff86952974e76f745bf376dc0/repository/s.json#L138-L147

Maybe make that a separate PR, I'll get this reviewed today or tomorrow

TheSpyder commented 1 year ago

I've opened a PR to package control, once that's merged we can safely merge this without breaking older editor versions. https://github.com/wbond/package_control_channel/pull/8798

Sorry it took a while to get to.