search

TheSpyder / rescript-nodejs

Node bindings for ReScript
MIT License
79 stars 15 forks source link

Support rescript v11 #16

Closed DZakh closed 1 year ago

DZakh commented 1 year ago
DZakh commented 1 year ago

Solves https://github.com/TheSpyder/rescript-nodejs/issues/15

TheSpyder commented 1 year ago

I appreciate you kickstarting this!

Long term I probably need to think about supporting uncurried mode, which looks like it will come alongside a switch to optional record fields for configuration objects, but we'll see what I have time for in the major version change.

The tests didn't compile (reminding me that I need to add CI), the easiest fix was upgrading to rescript-zora v4 which now uses async/await instead of the new promise bindings. Turned out to be fairly simple once I got the hang of it.

Thanks for enabling maintainer edits, I've just pushed that up - if you're ok with those changes I'll merge it and probably do a beta release on a new major version number.

DZakh commented 1 year ago

Looks good!

DZakh commented 1 year ago

I've copied the github action from my packages. It should work for now

TheSpyder commented 1 year ago

Ah nice, I was wondering which action to use for yarn. I'll merge it and see how we go.

DZakh commented 1 year ago

Ah, I've fucked up, haven't noticed that it's the pnpm action. I'll do a PR with a fix

TheSpyder commented 1 year ago

I was looking into that after I merged it but then something came up 😆

PR would be appreciated, thank you!