Closed MoOx closed 8 months ago
Interesting result https://github.com/MoOx/rescript-webapi/actions/runs/3399322177/jobs/5652997094
bsdoc
is missing...
Oh thank you! And yes bsdoc isn't installed by default, you'll need to add yarn doc-install
Note that the "tests" don't run, they're just a checked in copy of the generated JS files. So the other thing I think we need is a check to make sure compiling the project doesn't change the generated files (the expectation being that generated changes are checked in with the PR)
My favourite way to do this is git diff --quiet || ((echo "The following files changed:"; git status --porcelain); false)
which I assume the github action can manage 🤔
I finally added my own in https://github.com/TheSpyder/rescript-webapi/commit/10382431832c42be9dbdee1574d1627ccf705e85 - rather than test
as it was written, now I just verify there are no git changes after building.
Following #111 fail :)