search

TheSpyder / rescript-webapi

ReScript bindings to the DOM and other Web APIs
http://tinymce.github.io/rescript-webapi/api/Webapi/
Other
149 stars 36 forks source link

fix method parameter for requestInit with rescript v11 #129

Closed WhyThat closed 9 months ago

WhyThat commented 9 months ago

Hello, thanks for this package :)

Using @as directive as no impact for rescript v9 or v10 but it works in rescript v11

with rescript v9 image With rescript v10 image With rescript v11 image

fix #128

TheSpyder commented 9 months ago

Oh that's much better than how I was going to do it (I thought duplicate bindings would be required). Thanks!

We will eventually remove the _ (see #120) but this is a nice change that can be deployed safely.

TheSpyder commented 9 months ago

Published as 0.9.1 👍

WhyThat commented 9 months ago

Thanks for the quick release :)