Open utenma opened 2 months ago
@TheSpyder what do you do with the generated js files from tests? are they used besides compile check?
@utenma sorry I haven't looked at this yet. The "tests" are indeed a compile check; it ensures changes made do not impact the compiled JS (unless that's intentional).
I hope to one day have full library coverage, if you could add a few extra test calls to methods you've added that would be great 👍
Should we delete the old binding methods you're replacing?
updated list of breaking changes
As result of https://github.com/TheSpyder/rescript-webapi/issues/132
Path2d module added with following js bindings, see on MDN
Syntax
Changelog
Breaking
Updated common Path2d/Canvas2d params names to 1~3 characters matching mdn docs
ctx->quadraticCurveTo(~cp1x=1., ~cp1y=1., ~x=1., ~y=1.)
ctx->quadraticCurveTo(~cpx=1., ~cpy=1., ~x=1., ~y=1.)
ctx->arc(~x=1., ~y=1., ~r=4., ~startAngle=1., ~endAngle=3., ~anticw=true)
ctx->arc(~x=1., ~y=1., ~r=4., ~startAngle=1., ~endAngle=3., ~counterClockWise=true, ())
Added Path2d.make, Dropped Canvas2d.strokePath2D
let path = Path2d.make(~d="M24.85,10.126c2.018-4.783,6.628-8.125,11.99-8.125c7.223")
let path: path2d = newPath2D("M24.85,10.126c2.018-4.783,6.628-8.125,11.99-8.125c7.223")
Canvas2d functions taking Path2d renamed
TODO
src/Webapi/Webapi__Canvas.res
Canvas2d.newPath2D()
in favor ofPath2d.make(~d=?)
t
)